nats-io / nats-streaming-operator

NATS Streaming Operator
Apache License 2.0
174 stars 44 forks source link

Add NATS Streaming Operator Helm Chart #39

Closed Starefossen closed 4 years ago

Starefossen commented 5 years ago

This Pull Request adds a Helm chart for the NATS Streaming Operator similar to the NATS Operator (https://github.com/nats-io/nats-operator/tree/master/helm/nats-operator)

All suggestions, comments and improvements are welcome. Also thinking if we should submit this to the official chart repository to make it easy to install without having to git clone the repo.

TODO:

OTHER:

philicious commented 4 years ago

I like having a Helm Chart. thx @Starefossen !. Will try it out soon as I need to deploy and manage a nats-streaming cluster one way or another

tegk commented 4 years ago

Will be this merged?

omenv commented 4 years ago

Maybe it is a good way to add a new brunch for the helm-chart preparing. Also good to see options for persistence/SQL.

dellintosh commented 4 years ago

@Starefossen I have an open PR for your fork, if you get a moment to merge that in. It addresses a few of the concerns brought up, and I'm hoping that we can get this merged in.

So far, it addresses:

... TODO:

  • [x] Document values.yaml in README.md
  • [ ] Update NOTES.txt

OTHER:

  • [ ] liveness and readiness for NATS Streaming Operator deployment (blocked on #31)
  • [x] Cluster Scoped install similar to the NATS Operator?
  • [ ] Add nats-operator as a dependency to auto-install NATS Operator?

https://github.com/Starefossen/nats-streaming-operator/pull/1

wallyqs commented 4 years ago

@dellintosh thanks for the contribution, since there are some adopting the helm chart already I think we should merge as is and you can send PR here if you want.

wallyqs commented 4 years ago

Thanks a lot @Starefossen for the PR, sorry for the delay in merging... :bow: