nats-io / nats-top

A top-like tool for monitoring NATS servers.
https://nats.io
MIT License
354 stars 30 forks source link

nats-top --version keeps showing "nats-top v0.0.0" #102

Open jm20122012 opened 1 month ago

jm20122012 commented 1 month ago

What version were you using?

$ docker image ls --format "table {{.Repository}}\t {{.Tag}}"
REPOSITORY                                       TAG
nats                                             2.10.18-alpine3.20

What environment was the server running in?

$ lsb_release -a
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.6 LTS
Release:    20.04
Codename:   focal

Is this defect reproducible?

Yes. Running the nats-top --version command consistently outputs nats-top v0.0.0

$ nats-top --version
nats-top v0.0.0

Given the capability you are leveraging, describe your expectation?

I would expect the output to contain the appropriate nats-top version, which the version I downloaded was v0.6.2 as shown in the following output from the install:

$ go install github.com/nats-io/nats-top@v0.6.2
go: downloading github.com/nats-io/nats-top v0.6.2
go: downloading gopkg.in/gizak/termui.v1 v1.0.0-20151021151108-e62b5929642a
go: downloading golang.org/x/crypto v0.26.0
go: downloading golang.org/x/time v0.6.0
go: downloading golang.org/x/sys v0.24.0
go: downloading github.com/mattn/go-runewidth v0.0.16
go: downloading github.com/nsf/termbox-go v1.1.1

$ nats-top --version
nats-top v0.0.0

$ nats-top --help
usage: nats-top [-s server] [-m http_port] [-ms https_port] [-n num_connections] [-d delay_secs] [-r max] [-o FILE] [-l DELIMITER] [-sort by]
                [-cert FILE] [-key FILE] [-cacert FILE] [-k] [-b] [-v|--version] [-u|--display-subscriptions-column]

Given the expectation, what is the defect you are observing?

The defect is that the nats-top --version command is not showing the correct version, and instead just shows v0.0.0.

jm20122012 commented 1 month ago

It actually looks like "0.0.0" was hard-coded here. Was this intentional?