search

nats-io / nats.c

A C client for NATS
Apache License 2.0
382 stars 132 forks source link

[FIXED] GH-738, do not prefix endpoint name with the group prefix #741

Closed levb closed 4 months ago

levb commented 4 months ago

Fixes #738

The Go client does not prefix the name, it was a mistake. Now identify the EPs by subject, like the Go client

mtmk commented 4 months ago

fix looks good.

> nats micro list
╭───────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                             All Micro Services                                            │
├───────────────┬─────────┬────────────────────────┬────────────────────────────────────────────────────────┤
│ Name          │ Version │ ID                     │ Description                                            │
├───────────────┼─────────┼────────────────────────┼────────────────────────────────────────────────────────┤
│ c-arithmetics │ 1.0.0   │ Z77LYVHMUBP5HUIT6UNYQU │ Arithmetic operations - NATS microservice example in C │
╰───────────────┴─────────┴────────────────────────┴────────────────────────────────────────────────────────╯

did you want a review? you assigned to me but not a reviewer.

levb commented 4 months ago

@mtmk @Jarema Sry for misassignment, yes review please. This is a minor fix, about microservices.

levb commented 4 months ago

cherry-picked into release-v3.8

levb commented 4 months ago

Cherry-picked for v3.8.1, used the wrong branch before (removed it now)