nats-io / nats.c

A C client for NATS
Apache License 2.0
382 stars 132 forks source link

[ADDED] Build with GitHub actions #748

Closed levb closed 3 months ago

levb commented 4 months ago

Coverage checks should work for new PRs once this is merged to main and ran there.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@8099b5c). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #748 +/- ## ======================================= Coverage ? 68.76% ======================================= Files ? 38 Lines ? 15100 Branches ? 3119 ======================================= Hits ? 10384 Misses ? 1680 Partials ? 3036 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

levb commented 3 months ago

@kozlovic Can you please also review? I'll run it in parallel with Travis for a while. The "Release" build can be tested on your own branch if you remove the branch: main,... from on-push-release.yml

kozlovic commented 3 months ago

@levb By the way, I forgot to comment at the time, but some of the matrix tests are run 3 times, is it intentional or was it part of some debugging/test at the time you were writing the PR? There is nothing wrong running each test 3 times in a row, it may catch some issues that are timing based, but just wanted to make sure it was intentional.

levb commented 3 months ago

Intentional, so see the flappers more often.