search

nats-io / nats.c

A C client for NATS
Apache License 2.0
382 stars 132 forks source link

[TEST only] increased Test_KeyValueMirrorCrossDomains timeout value #753

Closed levb closed 3 months ago

levb commented 3 months ago

Fixes test failure against server main

From slack:

image
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.75%. Comparing base (58a7e24) to head (3658293). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #753 +/- ## ========================================== + Coverage 68.73% 68.75% +0.01% ========================================== Files 38 38 Lines 15100 15100 Branches 3119 3119 ========================================== + Hits 10379 10382 +3 + Misses 1686 1683 -3 Partials 3035 3035 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jnmoyne commented 3 months ago

LGTM. And that's because the retry interval was increased in the server, correct?

The HB interval for source/mirror consumers was increased from 1s to 5s yes