search

nats-io / nats.c

A C client for NATS
Apache License 2.0
382 stars 132 forks source link

[TEST ONLY] Fixed Test_JetStreamSubscribeIdleHeartbeat #764

Closed levb closed 2 months ago

levb commented 2 months ago

https://github.com/nats-io/nats-server/pull/5482/files#diff-c6e9a3ce0d55948f2e7ea75a4de309986654f2ab11e0f8750625b88b28bd9ebfR2833-R2838 broke this test. The test was faking a JetStream-delivered message, resulting in inaccurate ACKs being sent to the server. Disabled auto-ACKs for the relevant messages to avoid messing up the server state, and the test is now passing.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.70%. Comparing base (1cb8d8c) to head (92b9c7d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== + Coverage 68.68% 68.70% +0.01% ========================================== Files 39 39 Lines 15186 15186 Branches 3139 3139 ========================================== + Hits 10431 10434 +3 + Misses 1702 1699 -3 Partials 3053 3053 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.