search

nats-io / nats.java

Java client for NATS
Apache License 2.0
563 stars 153 forks source link

Switch to Eclipse Temurin and add SDKMan for local dev #1176

Closed artur-ciocanu closed 2 months ago

artur-ciocanu commented 2 months ago

Switch build from AdoptOpenJDK to Eclipse Temurin. Eclipse Temurin is the successor to AdoptOpenJDK and the team behind AdoptOpenJDK recommends switching to Eclipse Temurin. Here are some relevant links: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/, https://projects.eclipse.org/projects/adoptium.

.sdkmanrc - this file is used by SDKMan to switch between different Java versions. This is especially useful when you are working on different repositories and each repository uses a different Java version. SDKMan will use .sdkmanrc to switch to the right Java version and set JAVA_HOME to the right path. Here is the official SDKMan docs: https://sdkman.io/jdks.

artur-ciocanu commented 2 months ago

Hello @scottf could you please review this tiny PR.

Thank you 🙇‍♀️.

scottf commented 2 months ago

@artur-ciocanu Can you please provide some explanation for the reason to make this change. Please explain why Temurin over Adopt and then why add the ".sdkmanrc" file?

artur-ciocanu commented 2 months ago

@artur-ciocanu Can you please provide some explanation for the reason to make this change. Please explain why Temurin over Adopt and then why add the ".sdkmanrc" file?

Response moved to main comment by @scottf