search

nats-io / nats.net.v2

Full Async C# / .NET client for NATS
https://nats-io.github.io/nats.net.v2/
Apache License 2.0
202 stars 40 forks source link

Add ResumeAtRevision support to KV Watcher #491

Closed niklasfp closed 1 month ago

niklasfp commented 2 months ago

Resolves #478

niklasfp commented 2 months ago

@mtmk I'm seeing some test flappers in Watcher_reconnect_with_history and Watcher_timeout_reconnect locally (also without my changes)

Machine: Mac M2 Pro arm64

mtmk commented 2 months ago

@mtmk I'm seeing some test flappers in Watcher_reconnect_with_history and Watcher_timeout_reconnect locally (also without my changes)

Machine: Mac M2 Pro arm64

I'm not surprised. they're most stable on Linux at the moment. We also have #464 to deal with Windows flappers. we might open one for Mac too. I'm guessing it's mostly around managing the server process and sockets, but I might be wrong.

niklasfp commented 2 months ago

@mtmk I have not forgotten about this one, I'll get to it this weekend

mtmk commented 1 month ago

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

niklasfp commented 1 month ago

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

Omg thank u, and so sorry for not following up on this, life happened 🥲 I'll take a look today.

mtmk commented 1 month ago

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

Omg thank u, and so sorry for not following up on this, life happened 🥲 I'll take a look today.

thanks @niklasfp very kind of you 🙏 honestly, we really appreciate your contribution, you've done the hard work and I'm always happy to tie the loose ends when you don't have time 😅