nats-io / nats.net.v2

Full Async C# / .NET client for NATS
https://nats-io.github.io/nats.net.v2/
Apache License 2.0
202 stars 40 forks source link

Add KV Filtering of keys #545

Closed darkwatchuk closed 4 days ago

darkwatchuk commented 4 days ago

Resolves #521

rickdotnet commented 3 days ago

@mtmk , how important is this bit from the ADR? It looks as though it doesn't impact this implementation. Just making sure we don't need an additional check.

// When multiple filters are passed, client library should check `consumer info` from `consumer create method` if the filters are matching,
// as nats-server < 2.10 would ignore them.
mtmk commented 3 days ago

@mtmk , how important is this bit from the ADR? It looks as though it doesn't impact this implementation. Just making sure we don't need an additional check.

// When multiple filters are passed, client library should check `consumer info` from `consumer create method` if the filters are matching,
// as nats-server < 2.10 would ignore them.

@rickdotnet good point. created an issue for it: