Closed jaskij closed 2 months ago
Since your template doesn't have a field for comments: in your CI you should at least ensure every possible combination of feature flags builds, preferably test it to the extent possible. I have found cargo-hack
extremely useful for this.
Thanks for the report!
We can definately add this to Ci and of course fix the compilation.
However, I do not recommend running this crate with disabled default features, as those are related to working with older server versions.
Every new API or client feature is not enabled by default (like Service API).
However, I do not recommend running this crate with disabled default features, as those are related to working with older server versions.
Having read the feature flag description (thanks for the quick update!), yeah, I will definitely enable server_2_10
.
Observed behavior
When depending on
async-nats = "0.34.0
, if I setdefault-features = false
, it fails to build with the following error:Expected behavior
The crate builds and works as intended.
Server and client version
from my Cargo.toml
Host environment
up-to-date Arch Linux running on x86-64, building with current Rust stable
Steps to reproduce
Make a Rust crate depending on
async-nats
0.34.0 withdefault-features = false
. It fails to build.