nats-io / natscli

The NATS Command Line Interface
Apache License 2.0
453 stars 94 forks source link

Move audit checks logic to internal package #1063

Closed mprimi closed 1 month ago

mprimi commented 1 month ago

Refactor audit analyze command checks into and into a separate internal/audit package. Also move archive to internal and include some minor logging improvements.

ripienaar commented 1 month ago

Does this need to be public or can it go in internal/audit?

mprimi commented 1 month ago

Does this need to be public or can it go in internal/audit?

I suppose that's up to you, and wether you want folks to use this stuff as library or not. I have a weak preference for internal. Fewer users, fewer interrupts for me. Same for the archive package

ripienaar commented 1 month ago

Yes let’s start there and go public when we need to. We can’t go the other way once it ships :)

mprimi commented 1 month ago

Need to set up commit signing on this new laptop... ⏳