search

nats-io / natscli

The NATS Command Line Interface
Apache License 2.0
510 stars 99 forks source link

Add support for EDITOR with args to commands #1174

Closed joeriddles closed 1 month ago

joeriddles commented 1 month ago

closes #1173

Add support for EDITOR with args for commands that use EDITOR, like nats context edit.

This allows users to use something like code --wait for their EDITOR.

ripienaar commented 1 month ago

Looking good, I am slowly moving these utils into https://github.com/nats-io/natscli/blob/main/internal/util/util.go and its test to not pollute this package so much, be great to see these helpers moved there then we're good.

Sorry wasn't clear in earlier review about internal

ripienaar commented 1 month ago

Some typos also flagged by CI

joeriddles commented 1 month ago

Ah makes sense, I will move the new util functions over to internal/util.