search

nats-io / nsc

Tool for creating nkey/jwt based configurations
Apache License 2.0
98 stars 44 forks source link

nsc version on brew tap nats-io/nats-tools is outdated #635

Open jnehlmeier opened 7 months ago

jnehlmeier commented 7 months ago

What version were you using?

N/A

What environment was the server running in?

brew.sh Apple Silicon M1

Is this defect reproducible?

yes

Given the capability you are leveraging, describe your expectation?

The release process should also update brew tap nats-io/nats-tools so users can easily update nsc to latest released version.

Given the expectation, what is the defect you are observing?

Currently brew tap nats-io/nats-tools contains nsc version 2.7.6 which is pretty old. It seems the release process has stopped publishing new versions to brew tap.

aricart commented 7 months ago

@philpennock any thoughts - I see that the artifact is being uploaded if I look at https://github.com/nats-io/nsc/actions/runs/6894150547, but perhaps it is not the correct place?

jnehlmeier commented 7 months ago

@aricart @philpennock It looks like the .goreleaser config is outdated and

brews:
  tap:

should not be used anymore. Instead it should be:

brews:
  repository:

Compare both configs:

NSC vs. Nats CLI

In addition it seems like that Nats CLI allows Goreleaser to upload the brew release (skip_upload: false) while NSC has chosen to disable that upload (skip_upload: true). Instead the Github Actions workflow of NSC has an additional upload step. So once the .goreleaser config has been updated, that additional upload step needs to be checked.

jnehlmeier commented 7 months ago

And in the commit history of nats-io/homebrew-nats-tools you can see that @wallyqs has updated nsc manually 2 years ago.