search

nats-io / nsc

Tool for creating nkey/jwt based configurations
Apache License 2.0
101 stars 44 forks source link

[FIX] edit signing-key was unable to remove a connection type when in lowercase #665

Closed maxarndt closed 1 month ago

maxarndt commented 1 month ago

This change ensures that connection types are uppercased, and autofixes any type that is lowercase in an existing scoped signing-key.

In reference to #664

Please review carefully, this is my first contribution to nsc.

aricart commented 1 month ago

@maxarndt should be able to update the pr to the lastest main to pickup the ci changes that are failing the test.

maxarndt commented 1 month ago

@aricart thanks for the review! I rebased my branch. You can kick-off the pipelines again.