search

nats-io / prometheus-nats-exporter

A Prometheus exporter for NATS metrics
Apache License 2.0
381 stars 140 forks source link

Version is outdate #150

Open ali-ghasempor opened 3 years ago

ali-ghasempor commented 3 years ago

Hello, I think the version should be updated to v0.9.0 on main.go file for latest release. https://github.com/nats-io/prometheus-nats-exporter/blob/978b235e05d59485b7e03576bacf8e3d8925fbcb/main.go#L30

wallyqs commented 3 years ago

thanks, will fix in next release bump…

juanantoniocid commented 2 years ago

Did you already update it in the assets but not in the Docker image?

If I ask the version of the exporter within the Docker image for the 0.9.0 version, I get 0.8.0 (mismatches)

$ docker run -it --rm natsio/prometheus-nats-exporter:0.9.0 -version
prometheus-nats-exporter version 0.8.0

But if ask the exporter version from an asset in its 0.9.0 version, I get 0.9.0 (matches)

$ curl -L -o prometheus-nats-exporter.tar.gz https://github.com/nats-io/prometheus-nats-exporter/releases/download/v0.9.0/prometheus-nats-exporter-v0.9.0-darwin-amd64.tar.gz
$ tar -xvf prometheus-nats-exporter.tar.gz
$ prometheus-nats-exporter-v0.9.0-darwin-amd64/prometheus-nats-exporter -version
prometheus-nats-exporter version 0.9.0

The problem is that the version told by the Docker image mismatches with the version told by the asset, being both of them in the 0.9.0 version.