search

nats-io / prometheus-nats-exporter

A Prometheus exporter for NATS metrics
Apache License 2.0
381 stars 139 forks source link

NATS Server Dashboard using deprecated angular panels #283

Open betamos opened 8 months ago

betamos commented 8 months ago

What version were you using?

nats 2.10.12 nats-exporter 0.14.0 grafana v11.0.0-67348 (778d80f922)

I'm running the nats server on fly.io, using their Prometheus on Fly.io as a data source The grafana instance is running on grafanacloud free tier.

What environment was the server running in?

FROM natsio/prometheus-nats-exporter:0.14.0 AS prom

FROM nats:2.10.12 AS nats

FROM alpine:latest

COPY --from=nats /nats-server .
COPY --from=prom /prometheus-nats-exporter .

COPY server.conf server.conf
COPY start.sh start.sh

CMD ./start.sh

Is this defect reproducible?

I imported walkthrough/grafana-nats-dash.json into grafana upon creating a new dashboard.

Not sure when, but looks like grafana is doing a major deprecation of angular-based plugins, panels etc.

So yes, it is probably reproducible anywhere grafana runs above a certain version.

Given the capability you are leveraging, describe your expectation?

No warnings in grafana.

Given the expectation, what is the defect you are observing?

All panels give a warning "This panel requires Angular (deprecated)". Otherwise things works as expected. Note that the jetstream dashboard json works just fine, no warnings.

I tried the auto-migrate from the side-panel in edit mode, which converts the panel from type "Graph (old)" to "Time series". It seems to have worked - my graphs remain the same. I can not guarantee this works in all cases - my setup is quite simple.

Happy to export the JSON and send a PR. Let me know.

somratdutta commented 3 months ago

hey @betamos, I tried recreating this using the Grafana Cloud and Free Tier (w/o connecting to a Prometheus DS), but I got no such error. Can you make sure this issue still persists?

piotrpio commented 1 month ago

Hey @betamos. I can confirm what @somratdutta said, I don't see any warnings using grafana 11.2.0 (latest). Additionally, dashboards from walkthrough directory don't use any non-bundled plugins, so not sure which one would be causing an issue.