search

nats-io / stan.go

NATS Streaming System
https://nats.io
Apache License 2.0
706 stars 117 forks source link

[FIXED] No panic on protobuf Unmarshal errors #338

Closed kozlovic closed 3 years ago

kozlovic commented 3 years ago

Fix the Unmarshal possible overflow and also do not make the library panic on Unmarshal errors. We don't have a proper way to return those errors since they happen in callbacks. For now, just printing. May add a callback error later.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.5%) to 92.848% when pulling a4f322d7abece175cc21815ab48d664fff67e1c6 on no_panic_on_unmarshal_error into 22aa6ac93378d21e2644a7fad6e6ec601134ecc6 on master.