[FIXED] Prevent memory leak on subscription failure

nats-io / stan.go

NATS Streaming System

https://nats.io

Apache License 2.0

706 stars 117 forks source link

[FIXED] Prevent memory leak on subscription failure #366

Closed oncicaradupopovici closed 2 years ago

oncicaradupopovici commented 2 years ago

modified subscribe fn to unregister sub from subMap when subscribe fails
mofiifed TestSubTimeout test

fixes #365

oncicaradupopovici commented 2 years ago

Hello, I think there is a problem with your CI. Uogradeing to at least Go 1.17 should fix it.

kozlovic commented 2 years ago

Hello, I think there is a problem with your CI.

Yes, this project has not been updated for quite some time. I will update the Go versions. You may then want to rebase your PR when that is ready. I will ping here when that is done.

kozlovic commented 2 years ago

@oncicaradupopovici I have updated main branch with updated dependencies and CI. If you could, please rebase so that the tests can run once you have updated your PR. Thanks!

coveralls commented 2 years ago

Coverage increased (+0.09%) to 93.04% when pulling 3e2002b1d3ea9f3f97b3ae30ca02a0bb11fab58f on oncicaradupopovici:main into cfc73f3f12537cc31b1c6b0ba699e736909be19a on nats-io:main.

oncicaradupopovici commented 2 years ago

@kozlovic I have rebased and implemented the requested changes (strongly agree with those). Thanks!

oncicaradupopovici commented 2 years ago

Can we have a release, so I can close my issue on my side? Thank you!

kozlovic commented 2 years ago

Ok, I will release v0.10.3.

kozlovic commented 2 years ago

Done: https://github.com/nats-io/stan.go/releases/tag/v0.10.3