search

nats-io / terraform-provider-jetstream

Terraform Provider to manage NATS JetStream
Apache License 2.0
55 stars 13 forks source link

Implement support for provider root CA configuration #37

Closed rickardgranberg closed 2 years ago

rickardgranberg commented 3 years ago

This is a suggested implementation to fix issue #23

rickardgranberg commented 3 years ago

Not sure I understand why the build failed... Tried running staticcheck on my machine and I don't see that error. And I haven't added/changed any dependencies either

ripienaar commented 3 years ago

hmm, if you go go mod tidy no changes?

rickardgranberg commented 3 years ago

hmm, if you go go mod tidy no changes?

No, does nothing. I even tried go mod tidy -compat=1.16 in case there was something caused by me having Go 1.17 installed, but still nothing. I also tried to do what the build suggested (go get ...), but that did not add anything to go.sum either (and a go mod tidy after adding them just removed the deps from go.mod again)

rickardgranberg commented 3 years ago

OK, it was caused by me using Go 1.17. I spun up a dev container in VS Code with Go 1.16 and was able to reproduce the issue.

ripienaar commented 3 years ago

Ah yes, that'll do it.

OK I will take a look at this next week, this week got a bit crazy, thanks a lot

ripienaar commented 2 years ago

This is great thanks, I'll look to add other connection options like user/pass/token etc as well, might then also support cert and key as tls options.