search

nattaponaie / nimble-challenge

0 stars 0 forks source link

Unexpected empty and missing scraping results #14

Open olivierobert opened 5 years ago

olivierobert commented 5 years ago

I uploaded a CSV file with the following content:

rails,ruby,developer job

Which got processed in the PIA request as:

image

Resulting in the following results:

Nimble_Search

The first issue is that there is no validation for an empty keyword. There is no point in scraping google search results for an empty string 😅

Second, the parser does not seem to work on all accepted CSV formats:

1

rails,ruby,developer job

2

rails
ruby
developer
job

3

keyword # column header
rails
ruby
developer
job

If there are any limitation or the form expect a specific format, prefer informing the user about hos data must be uploaded and/or provide a template file.

olivierobert commented 5 years ago

Since it's a parsing issue, that's where testing can be a saver 💪

toey___Volumes_Workspace__candidates-tests_toey__-_____web_utils_papaParse_js

nattaponaie commented 5 years ago

Thank you for the issues, this seems to be a crucial things to handle so I will open a pull request for this one.

nattaponaie commented 5 years ago

This issue has been solved in the latest pull request.