search

natto-maki / ComfyUI-NegiTools

Apache License 2.0
30 stars 4 forks source link

[FIX] Fix the error when importing from comfyui_controlnet_aux. #4

Closed ParticleDog closed 9 months ago

ParticleDog commented 10 months ago

The code of node comfyui_controlnet_aux has changed, errors occur when comfyui inits.

natto-maki commented 10 months ago

Thanks your feedback! OpenPoseToPointList refers to controlnet_aux, not comfyui_controlnet_aux. And the code for both is different, the controlnet_aux included in comfyui_controlnet_aux is missing the resize_image function as you pointed out. At first I thought that since it references controlnet_aux that it wouldn't cause a problem, but there are some environments where this can be a problem?

Actually, resize_image is not a complicated function, so I think we can copy its implementation to OpenPoseToPointList. What do you think?

ParticleDog commented 10 months ago

Oh I get it. It's wired that it imports from comfyui_controlnet_aux's code but not from the environment. Perhaps you could make a copy of controlnet_aux in your code just like what comfyui_controlnet_aux did. Who knows what other pitfalls are hidden within the code difference.

natto-maki commented 9 months ago

Fixed in Release v0.3.3 including related bugs