natural-harmonia-gropius / hdr-toys

Componentized Rec.2100 to Rec.709 conversion shader for mpv-player, featuring dynamic curves and a uniform color space.
MIT License
112 stars 1 forks source link

Colors washed out #57

Closed mario-g98 closed 4 months ago

mario-g98 commented 5 months ago

Maybe I don't know how to set it up correctly , but the the colors look washed out.

this is my mpv.conf:

hwdec=vaapi
vo=gpu-next

osd-bar=no
border=no
osc=no

hr-seek=yes
fs=yes

[bt.2100-pq]
profile-cond=get("video-params/primaries") == "bt.2020" and get("video-params/gamma") == "pq"
profile-restore=copy
target-prim=bt.2020 
target-trc=pq
glsl-shader=~~/shaders/hdr-toys/utils/clip_both.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/pq_inv.glsl
glsl-shader=~~/shaders/hdr-toys/utils/chroma_correction.glsl
glsl-shader=~~/shaders/hdr-toys/tone-mapping/dynamic.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

[bt.2100-hlg]
profile-cond=get("video-params/primaries") == "bt.2020" and get("video-params/gamma") == "hlg"
profile-restore=copy
target-prim=bt.2020
target-trc=hlg
glsl-shader=~~/shaders/hdr-toys/utils/clip_both.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/hlg_inv.glsl
glsl-shader=~~/shaders/hdr-toys/utils/chroma_correction.glsl
glsl-shader=~~/shaders/hdr-toys/tone-mapping/dynamic.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

[bt.2020]
profile-cond=get("video-params/primaries") == "bt.2020" and get("video-params/gamma") == "bt.1886"
profile-restore=copy
target-prim=bt.2020
target-trc=bt.1886
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886_inv.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

[dovi-p5]
profile-cond=get("video-params/primaries") == "bt.709" and get("video-params/gamma") == "bt.1886" and get("video-out-params/max-luma") > 203
profile-restore=copy
target-prim=bt.2020
target-trc=pq
glsl-shader=~~/shaders/hdr-toys/utils/clip_both.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/pq_inv.glsl
glsl-shader=~~/shaders/hdr-toys/utils/chroma_correction.glsl
glsl-shader=~~/shaders/hdr-toys/tone-mapping/dynamic.glsl
glsl-shader=~~/shaders/hdr-toys/gamut-mapping/jedypod.glsl
glsl-shader=~~/shaders/hdr-toys/transfer-function/bt1886.glsl

Screenshot from 2024-01-23 22-46-39

natural-harmonia-gropius commented 5 months ago

Any thing in mpv's console? press ` (under esc to show it)

I guess you are using old mpv with out libplacebo dependencies. I don't know how mpv got installed in linux, but https://aur.archlinux.org/packages/mpv-full-git may be helpful for you.

mario-g98 commented 5 months ago

Edit: Thank you for the response!

I am running version 0.37 on arch

Using hardware decoding (vaapi).
[auto_profiles] Applying auto profile: bt.2100-pq 
AO: [pipewire] 48000Hz 7.1 8ch floatp
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/utils/clip_both.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/utils/clip_both.glsl.
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/transfer-function/pq_inv.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/transfer-function/pq_inv.glsl.
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/utils/chroma_correction.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/utils/chroma_correction.glsl.
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/tone-mapping/dynamic.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/tone-mapping/dynamic.glsl.
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/gamut-mapping/jedypod.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/gamut-mapping/jedypod.glsl.
[file] Cannot open file '/home/mario/.config/mpv/shaders/hdr-toys/transfer-function/bt1886.glsl': No such file or directory
Failed to open /home/mario/.config/mpv/shaders/hdr-toys/transfer-function/bt1886.glsl.
VO: [gpu-next] 3840x2160 vaapi[p010]
natural-harmonia-gropius commented 5 months ago

have you copied those files to their locations?

image

mario-g98 commented 5 months ago

I had somehow messed up the folder structure. I feel stupid. Now it is working, thank you!

Is it normal to have a slight lag? I am on Dell XPS 9500 with Intel i7-10750H, the cpu usage is around 6%. But the playback is a bit choppy.

natural-harmonia-gropius commented 5 months ago

Not normal. You can press shift+i then press 2 to get the timing info of shaders.

mario-g98 commented 5 months ago

I am getting peak μs of around 100 000.

Screenshot from 2024-01-24 09-48-45

natural-harmonia-gropius commented 5 months ago

If you play without hdr-toys it will be smooth?

As you can see the upscaling cost most, try to change it to hermite or something cost less. --scale

mario-g98 commented 5 months ago

Changing the scale to hermite solved the problem, thank you.

geextahslex commented 4 months ago

you can leave out 'chroma correction' and drop dithering down to 8 bit, if you are on a SDR monitor/tv

if your issue is sovled you can click on "close issue"