Open geextahslex opened 9 months ago
"simple" HDR "bt.2020" (HDR movies on UHD blurays)
I don't know what exactly it is, but all profiles in https://github.com/natural-harmonia-gropius/hdr-toys/blob/master/hdr-toys.conf.
If you mean the default setup, the results aren't very pleasing. And jedypod gives a more washed out look than lea..
the results aren't very pleasing
Screenshots please, or sample files.
jedypod gives a more washed out look than lea..
Try latest version (master branch) rather than release one.
ok so I took some time and compared them a bit. If I could pick I would take the color and saturation from the latest jedypod but the luminance from oldschool lea, it's a punchy picture lea jedypod (master)
what about bottosson (master)?
bottosson (master) slightly changes the contrast but the "black levels" (marked yellow in the picture) stays overall the same bottosson:
With all things in master (dynamic, bt1886), it still not blacks enough? If so, I'll create another shader for extra contrast, math of lut in lea is most likely wrong.
And if you can, upload a short clip to me for investigate ffmpeg -i input.mkv -ss 00:00 -t 10 output.mkv
.
here I matched the black levels (in photoshop) between jedypod and lea, this looks awesome
I never made a clip, how does this work?
download ffmpeg https://www.gyan.dev/ffmpeg/builds/ffmpeg-release-essentials.zip
open folder of this video
copy /bin/ffmpeg.exe into this folder
left click with explorer, open in terminal
input ./ffmpeg -i input.mkv -ss 00:00 -t 10 output.mkv
in terminal. (change input.mkv to your filename, 00:00 to time of this scene.)
drag output.mkv to github's input box, waiting for uploading.
okay github says "We don’t support that file type. Try again with..." I think .mkv is not supported
mp4 should be fine
and how do I achieve that?
./ffmpeg -i input.mkv -ss 00:00 -t 10 output.mkv
simply change output.mkv to output.mp4
or compress a zip maybe works.
okay, the last frame is the one I used in the screenshots https://github.com/natural-harmonia-gropius/hdr-toys/assets/139760266/ef41dae8-a43f-4cef-9c09-a4e058538b47
this is the cropped og file test_2.zip
This is the screenshot from my current config, try to get a clean setup (master branch).
after installation steps, any errors in console (press `
). If not, press shift+i
then press 2
, should be these things in here.
and one more suggestion: add glsl-shader-opts=L_sdr=100
to your mpv.conf, that most movies use this value.
okay, so my PC is not capable of running dynamic so I took bt2446c, and here you can see how the blacks are crushed normal mpv latest master with bt2446c instead of dynamic, with "glsl-shader-opts=L_sdr=100" added dynamic is better, but is oversaturated and has artifacts, and I can not run it ^^
For master branch you need to add glsl-shader=~~/shaders/hdr-toys/utils/black_point_compensation.glsl
after bt2446c line to fix "black crush"
About saturation, better compared to Windows Media Player (win11 one) with https://apps.microsoft.com/detail/9PLTG1LWPHLF, for dolby vision files, that is the references.
okay that black_point_compensation worked, but why isn't it in the profile? how should a user know this?
I don't understand what you mean by the Windows Media Player thing`?
I would recommend setting glsl-shader-opts=L_sdr at 150, cause at 100 the picture looks like it would glow.
but why isn't it in the profile?
dynamic and bt2390 included this functionality itself.
how should a user know this?
I will update README, someday.
I don't understand what you mean by the Windows Media Player thing`?
It's dolby's official tonemapper, only works with Windows Media Player. As your clip seems a dolbyvision file.
https://apps.microsoft.com/detail/9WZDNCRFJ3PT https://apps.microsoft.com/detail/9PLTG1LWPHLF
okay but on the main page you are suggesting to use bt2446c instead of dynamic and I myself tried it some time ago, I have seen the crushed blacks and just moved on, so this would be a vital information. Maybe make a * info under or something in brackets.
Yes a readme would be nice like mpv as there are many options (utils) and how to know when to use them, and whats the effect of them.
WMP: okay good to know, the picture looks nice bright and contrasty but using something else than mpv for video playback is out of question, but it's a nice reference point
you are suggesting to use bt2446c instead of dynamic
nope, just an old example for replace. dynamic is the only one I tuned; others are in book implement.
okay are there any chances for performance gains with dynamic? as I get like 12 FPS on average, lol it seems to be heavy on the gpu not cpu
are there any chances for performance gains with dynamic?
I have no idea, although it is indeed many wastes of performance. 😗
okay I have made some comparisons. all set to 150 nits my vanilla setup (old lea hdr-toys) dynamic bottosson dynamic jedypod bt2446c bottosson bt2446c jedypod bt2390 bottosson bt2390 jedypod
so I am now using bt2446c bottosson, and I noticed clipping in the highlights. Do you know how to fix this, is there a glsl for this? clipping on the nose and forehead missing details
"clipping" is well exposure picture, the face below looks dull and bloodless.
Also, jedypod's face is too yellowish, bottosson is better here.
clipping is loosing details, you can see the white patch on his beard. I also noticed clipping in clouds
"the face below looks dull and bloodless"
yes but this is only for representation purpose
"Also, jedypod's face is too yellowish, bottosson is better here."
yap, thats why I went with bottosson
okay so any way to compress the highlights? bring them back? if there is a black_point_compensation for crushed blacks, could there not also be a "white_point_compensation" for clipped highlights? just turn the concept around? ^^
okay I made this in photoshop, I took the highlights from the one picture and merged them. it's not perfect but it shows the idea
okay so any way to compress the highlights? bring them back?
2446c curve is https://www.desmos.com/calculator/1dwlw3ultd (red one). in code k1 and k3 as is, t is ip. Generally you can increase k3 to get more highlight details.
unfortunately this value (k3) only dimms the clipped area but it doesn't recover any highlights :(
What about the result of tone-mapping/linear?
linear instead of 2446c? looks bad
I fixed linear in yesterday, update it.
okay but now the whole picture gets dark, so now we are back at the beginning where you said:
the face below looks dull and bloodless
There's no silver bullet, try creating a custom curve.
it seems so ^^
try creating a custom curve
how? where is the "t" in the glsl 2446c file?
do you have a st2094-10 glsl shader?
how? where is the "t" in the glsl 2446c file?
ip
do you have a st2094-10 glsl shader?
with hdr-toys.conf
remove
tone-mapping=clip
gamut-mapping-mode=clip
copy bt.2020 target-prim... to others, you can use mpv's tone-mapping with bottosson.
I got them close but the colors behave different now before after (2094-10)
I have no idea about 2094-10, It's part of libplacebo(mpv gpu-next).
okay, 2094 gives really good luminance, no clipping, bright image but something feels off in dark colors/shadow. Looks weird in this pipeline before (reinhard) after (2094)
Again, I have no idea about that. report "feels off" to libplacebo/mpv.
is there a way to modify reinhard to don't tame the peaks that much? normal reinhard
I have found a version that is called "Extended Reinhard" it adds a variable "white point". On the screenshots you can see that it allows more controll over the max luminance/the peaks.
source: https://64.github.io/tonemapping/
normal reinhard Extended Reinhard
https://github.com/natural-harmonia-gropius/hdr-toys/blob/master/shaders/hdr-toys/tone-mapping/reinhard.glsl is "Extended Reinhard", peak can be modified by glsl-shader-opts=L_hdr=1000.
haha you know what? thats what I thought ^^ because of "(1.0 + x / (w * w))" that looked similar okay I played around with glsl-shader-opts=L_hdr but I'm confused. It doesn't matter what I set it to 300 or 10.000 it always makes the image one notch darker. I only wanted to change the highlights not the midtones. no L_hdr change with any modification
reinhard is not a piecewise curve, you need something like hable2.
I don't know, in this comparison you can see that the only difference are the peaks in the windows and slightly saturation normal reinhard Reinhard luminance (white point = max luminance) source https://64.github.io/tonemapping/
hdr-toys' reinhard is luminance.
reinhard is not a piecewise curve, you need something like hable2.
hable2 is the darkest of them
try to lower the shoulderAngle
Hi, I want to ask if there is a chance for a "simple" HDR "bt.2020" (HDR movies on UHD blurays) to SDR (normal TV) profile. This would be very useful.
Thank you