search

natural-harmonia-gropius / input-event

Enhanced input.conf for mpv-player. with better, conflict-free, low-latency event mechanism.
MIT License
51 stars 5 forks source link

It broke scroll-list.lua functionality #34

Closed WhoMI7 closed 1 year ago

WhoMI7 commented 1 year ago

https://github.com/CogentRedTester/mpv-scroll-list I use chapter-list.lua Scroll wheel and UP, DOWN were used to scroll among chapters. UP, Down and Scroll Wheel are now just changing volume.

natural-harmonia-gropius commented 1 year ago

Can you share your input.conf? For me, it works.

WhoMI7 commented 1 year ago

input.conf isn't required since just dropping inputevent.lua to my scripts folder makes chapterlist.lua to ignore

add_keys(o.key_scroll_down, 'scroll_down', function() list:scroll_down() end, { repeatable = true })
add_keys(o.key_scroll_up, 'scroll_up', function() list:scroll_up() end, { repeatable = true })
add_keys(o.key_move_pageup, 'move_pageup', function() list:move_pageup() end, {})
add_keys(o.key_move_pagedown, 'move_pagedown', function() list:move_pagedown() end, {})
add_keys(o.key_move_begin, 'move_begin', function() list:move_begin() end, {})
add_keys(o.key_move_end, 'move_end', function() list:move_end() end, {})
add_keys(o.key_open_chapter, 'open_chapter', open_chapter, {})
add_keys(o.key_close_browser, 'close_browser', function() list:close() end, {})

But it doesn't hamper mp.register_script_message("toggle-chapter-browser", function() list:toggle() end) since it is in my input.conf TAB script-message-to chapter_list toggle-chapter-browser. Maybe it can be fixed by adding them in input.conf? But then again I use UP, DOWN and scroll wheel for volume. And their function is only different when toggle-chapter-browser is in focus.

natural-harmonia-gropius commented 1 year ago

Weird, I just add script-message-to chapter_list toggle-chapter-browser too. Can you show your shift+i 4? See what's taking up wheel_up.

image image

WhoMI7 commented 1 year ago

image Also I just noticed, I can click on timeline with left click now. I had buttons in uosc as some binds even they stopped working, though I can use them using keybinds Almost everything broke.

natural-harmonia-gropius commented 1 year ago

You can scroll down this page to find the wheel_up and wheel_down.

Does everything work well if you delete inputevent.lua?

WhoMI7 commented 1 year ago

Does everything work well if you delete inputevent.lua?

Yes.

Dynamic keybinds just vanished. image

natural-harmonia-gropius commented 1 year ago

Any error or warning in console? " ` " <- default tothis key to open console

WhoMI7 commented 1 year ago

Any error or warning in console? " ` " <- default tothis key to open console

No, nothing.

https://user-images.githubusercontent.com/93109835/213679825-f6261b12-6861-4cc8-8eb0-3608db2b0ef8.mp4

Current issues I found:

  1. Dynamic keybinds ignored.
  2. Can't use uosc buttons. (can't even close using the cross on top right corner).
  3. The only keybinds working are the ones written in input.conf
natural-harmonia-gropius commented 1 year ago

I have no idea what's happening here.

Can you upload your mpv.conf?

If you delete this part (at end of inputevent.lua), does everything works? image

WhoMI7 commented 1 year ago

Upon closer inspection, this seems to be an issue of another script/or maybe mpv. Sorry for wasting your time.