natural-harmonia-gropius / input-event

InputEvent.lua for mpv-player, enhanced input.conf with better, conflict-free, low-latency event mechanism.
MIT License
39 stars 5 forks source link

Add option.prefix #51

Closed natural-harmonia-gropius closed 3 months ago

natural-harmonia-gropius commented 3 months ago

Very direct and simple solution, no extra costs. alt to https://github.com/natural-harmonia-gropius/input-event/pull/46 and https://github.com/natural-harmonia-gropius/input-event/pull/47.

mpv.conf

script-opts-append=inputevent-prefix=event:

input.conf

MBTN_LEFT           cycle pause                                                 #event: click
MBTN_LEFT           cycle fullscreen                                            #event: double_click

@tylandercasper @Mark-Joy Any advice?

tylandercasper commented 3 months ago

I think if "event:" is the default going forward than its a cleaner solution.

If it's not the default going forward than the problem is that users get conflicts without knowing that input-event is causing those conflicts. I'm guessing @Mark-Joy was similarly confused at first

Ideally it would be nice to have both the prettier event: clicked syntax and have it bind only to events it can actually respond to.

natural-harmonia-gropius commented 3 months ago

I think if "event:" is the default going forward than its a cleaner solution.

Breaking change. Put on hold, I want to write a better input.conf parser first.

have it bind only to events it can actually respond to

Okay, I will create a commit with you two as co-author in tomorrow. 👌

natural-harmonia-gropius commented 3 months ago

closed by https://github.com/natural-harmonia-gropius/input-event/commit/b996caa4f7a11ac524da10e1a8c700344d9abae9