search

naturalatlas / node-gdal

Node.js bindings for GDAL (Geospatial Data Abstraction Library)
http://naturalatlas.github.io/node-gdal/classes/gdal.html
Apache License 2.0
567 stars 124 forks source link

node v12 support #258

Closed christophemacabiau closed 4 years ago

christophemacabiau commented 5 years ago

When compiling with node v12.3.1, I get this nan error:

In file included from ../../nan/nan_new.h:189,
                 from ../../nan/nan.h:203,
                 from ../src/utils/fast_buffer.hpp:11,
                 from ../src/utils/fast_buffer.cpp:4:
../../nan/nan_implementation_12_inl.h: In static member function ‘static Nan::imp::FactoryBase<v8::Function>::return_t Nan::imp::Factory<v8::Function>::New(Nan::FunctionCallback, v8::Local<v8::Value>)’:
../../nan/nan_implementation_12_inl.h:105:32: error: no matching function for call to ‘v8::Function::New(v8::Isolate*&, void (&)(const v8::FunctionCallbackInfo<v8::Value>&), v8::Local<v8::Object>&)’
                           , obj));
jdesboeufs commented 4 years ago

Hello.

Node.js 12 is now an official LTS and we still don't have a prebuilt package for this version. I think it's time to allow some additional maintainers ;)

wandergis commented 4 years ago

wish node v12 support too.

jdesboeufs commented 4 years ago

See #267 :(

ezze commented 4 years ago

My attempt to install the library on Node 12 and Ubuntu 18.04 also fails. :(

yocontra commented 4 years ago

This is working on all node versions - https://github.com/contra/node-gdal-next