naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.09k stars 326 forks source link

Missing glyphs in PHB fonts #116

Open GAZ082 opened 8 years ago

GAZ082 commented 8 years ago

Hello there. Beautiful piece of software you've made. But have an issue, apparently, the font used as standard text does not have latin characters (such as áéíóú, ñ, ¡,¿) and instead renders the fallback font, which is noticeably bigger.

Dont know if something can be made, as this is a thing the font maker should address, but hey.

Thanks!

stolksdorf commented 8 years ago

Sorry about your issue! You are right, there's not a ton I can do. I have a font guy I'll chat with and see how difficult it would be to add. Thanks for the report!

GAZ082 commented 8 years ago

LOL, you replied so fast i thought it was an auto response, haha. Thank you man.

stolksdorf commented 8 years ago

The Homebrewery uses 4 fonts: Main Serif, main Sans serif, headers, and the fancy first letter. Which ones do latin characters not work on?

Also, summoning @mimosacb to help out with fonts.

mimosacb commented 8 years ago

I'll take a look at the source font files later today, but if the glyphs aren't included the best we can do is replace the font with one that has them. Next best thing would be to find a fallback with similar metrics.

GAZ082 commented 8 years ago

It's a mix. The heading font is ok but lacks the (¡), odd, since it has the (¿) The normal font is the one with the less features. I made a document for you to check!

http://www.naturalcrit.com/homebrew/edit/BklarITFm

I think this also would be a good opportunitiy to work more on the fonts, ie, i forsee in a near future some germanic speaker (german, swedish, norwegian, etc.) asking for some special symbols.

Thanks!

mimosacb commented 8 years ago

Looks like the small cap source is incomplete, for now you could use Baskerville as a fallback since it looks like the header font is based on that. I’ll try to find a more complete source for that one.

For the body serif font you could use TeX Gyre Bonum as a fallback, or even just replace the whole font with it as they are both Bookman/Caslon derivatives and therefore extremely similar.

The drop cap (fancy first letter) appears to have pretty limited support, though that’s almost to be expected. The likelihood for the first letter of the first word to be accented is somewhat lower, so it’s up to you if you really want to hunt something down.

I haven't noticed any problems with the sans serif missing any glyphs.

Idrinth commented 8 years ago

@mimosacb there's quite a few words starting with Ä, Ö and Ü in german, some of them could easily start a paragraph or have an upper case letter in the headers(all nouns start upper-case).

Magische Öle und ähnliche Flüssigkeiten (magic oils and similar liquids) Would work with an alchemist-like class for example, ends up with a number instead of the Ö.

If replacing the font is hard to do, you could have a look at latinizing those letters properly if they are upper case. Might be a quicker solution I assume.

calculuschild commented 4 years ago

The font currently used for the standard paragraph text is "BookInsanity", an open-source font created by Reddit user Solbera, based on the commercial font used by Wizards of the Coast, "BookMania". Use of the open-source avoids some nebulous legal and copyright issues if users want to sell their Homebrewery creations.

However, it has come to my attention that some other Reddit users have fixed and updated the BookInsanity fonts and they appear to include these additional latin characters. I'm going to test the updated BookInsanity font and maybe we can finally fix this issue.

calculuschild commented 3 years ago

Another Reddit user posted some tweaks to better position the capitalized letters in the Header fonts:

https://www.reddit.com/r/homebrewery/comments/kjoo29/solbera_imitation_tweak/

AlexeySachkov commented 3 years ago

There is a repo where several Solbera's fonts are stored and maintained (I hope so): https://github.com/jonathonf/solbera-dnd-fonts

calculuschild commented 3 years ago

Yep those are the fixed fonts I found earlier. Thanks for linking it up. This should be a pretty easy fix if someone wants to make a PR for it (I'm focusing on some other items at the moment).

ericscheid commented 3 years ago

See also https://www.reddit.com/r/homebrewery/comments/le2r98/

calculuschild commented 3 years ago

Reddit user who added accents and fixed some kerning issues on most of the fonts. https://www.reddit.com/r/UnearthedArcana/comments/71wzc2/new_indesign_template_and_open_source_fonts/

Gazook89 commented 3 years ago

There is a repo where several Solbera's fonts are stored and maintained (I hope so): https://github.com/jonathonf/solbera-dnd-fonts

This repo just updated their fonts with the updated ones from that Reddit thread

ericscheid commented 3 years ago

Something weird is happening with the MrJeeves font used for brew titles on /user/name page vs what appears on the brew page. I can't see where the CSS is different.

image

image

calculuschild commented 3 years ago

@ericscheid You have different characters in the two examples, ė and é . é is supported in the font but the other is not.

ericscheid commented 3 years ago

@ericscheid You have different characters in the two examples, ė and é . é is supported in the font but the other is not.

Oooh, well spotted. Though I now have no idea how ė got there — there is no handy or accidental keypress in Mac OS to type that.

ė not being supported in the font is (mostly) fine, it isn't a common diacritic. We might upset the Lithuanians, but that's about it.

calculuschild commented 3 years ago

Closing! This has been added to the V3 renderer via #1267

No plans to add this to Legacy.

ericscheid commented 2 years ago

Re-opening since some characters are still missing umlautes.

Some of those caps with diaeresis are not in common language use, but Ö is a specific example called out above.

some caps missing umlautes

calculuschild commented 2 years ago

A Reddit post with details on some other possibly missing characters. Link to example brew: https://homebrewery.naturalcrit.com/share/_UFl9V3IYuZ8

Gazook89 commented 2 years ago

Is there a 'finish point' for this issue such that it can be closed? If so, what is it? A glyph for n unicode characters on every default font included with Homebrewery?

Glyphr Studio looks like a promising free tool for doing some font work as long as we don't need lots of different settings....Since @calculuschild seems to be at least somewhat familiar with font editing, could you take a look at Glyphr and determine if it will work for what needs to be done on this Issue or if it's going to only get us halfway?

If Glyphr will work, and we can set a series of milestones and guidelines, perhaps this issue can be banged out fairly quickly amongst a few users. Something like:

Milestones

Complete glyphs outlined on this brew for these fonts:

I would volunteer to do this but just don't want to have to do it twice due to misunderstanding some small thing. And if it's enough to just get the Ö done, then great.

5e-Cleric commented 10 months ago

I have worked with Glyphr studio, and can guarantee it can very much help with this issue, what kind of milestones would you suggest?

5e-Cleric commented 9 months ago

Going to use this brew to test fonts from now on, and i suggest we stick to Basic Latin + Latin-1 Supplement.