iframe loop leads to duplicate header

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown

https://homebrewery.naturalcrit.com

MIT License

1.09k stars 326 forks source link

iframe loop leads to duplicate header #1293

Open lukearndt opened 3 years ago

lukearndt commented 3 years ago

Hello, thanks for this wonderful tool.

Since a recent update, I've experienced an issue where the page renders the header several times:

Looking at the HTML, it appears that there's an iframe loop going on:

This doesn't occur every time; it seems to be intermittent. When it does occur, refreshing the page generates an additional iframe layer each time. It doesn't seem to have any kind of limit. The page looks pretty funny with 9 headers on it. 😄

Visiting the page directly via its URL clears the extra headers. From there, I can reproduce it by closing the tab and reopening it with the "undo closed tab" browser control (control+shift+t).

I'm using the latest version of Firefox on Windows 10.

G-Ambatte commented 3 years ago

I have also run across this recently, Ctrl+Shift+R in Firefox forces a refresh that clears it. Unfortunately that's about as far as I have managed to progress in investigating it at this time.

It is worth noting that Chrome is Homebrewery's officially supported browser, not Firefox. Despite this, many of us (myself included) use FF anyway.

Gazook89 commented 1 year ago

From @ericscheid today in gitter:

FWIW, I have managed to achieve and reproduce this borked situation repeatedly. The trick is to click multiple in-page link (e.g. in a ToC), and to use the browser Back History function (back key, or cmd-[, or whatever).

IIRC though, this sometimes also happens to a freshly loaded URL.

5e-Cleric commented 2 months ago

From @ericscheid today in gitter:

I opened a new window, loaded /new, tossed in some brew.text .. .. then closed the tab/window .. then used the browser's open-last-closed-tab command

It does not occur if I .. .. close the tab/window .. opened a new tab and entered the /new url directly

This is on firefox, not chrome. Cannot repro on chrome.

So .. umm .. not an "us" bug, but instead a firefox bug?

5e-Cleric commented 1 month ago

This issue doesn't happen often enough to need our attention, a refresh fixes it on the spot, and it might be a browser bug, considering closing this.