naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.07k stars 326 forks source link

Firefox: FontAwesome Icons gone missing? #1548

Open Gazook89 opened 3 years ago

Gazook89 commented 3 years ago

Hey, on my Docker build the font awesome icons are all missing, and console has a whole lotta this:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-solid-900.ttf. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

downloadable font: download failed (font-family: "Font Awesome 5 Free" style:normal weight:900 stretch:100 src index:3): bad URI or cross-site access not allowed source: https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-solid-900.ttf
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-regular-400.ttf. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

downloadable font: download failed (font-family: "Font Awesome 5 Free" style:normal weight:400 stretch:100 src index:3): bad URI or cross-site access not allowed source: https://use.fontawesome.com/releases/v5.15.1/webfonts/fa-regular-400.ttf

I thought it was due to some changes to snippet bar I made on a branch, but having the same issue on my master branch that I haven't touched besides merging upstream/master into it. Also, it's ALL icons, not just in the snippet bar.

ericscheid commented 3 years ago

I saw a few cross-site cookie warnings for font-awesome the other day. They seem to have gone away now. I suspect a hiccup with them changing their hosting arrangement. Give it a day, see if issue persists.

calculuschild commented 2 years ago

@Gazook89 is this still an issue on the Docker stuff?

Gazook89 commented 2 years ago

I found this question/answer on the mozilla forums regarding this. I was wrong when I opened this issue-- it's not a Docker thing, it's a Firefox thing and at the time it didn't even occur to me to try it in Chrome.

The above link offers a solution (changing a flag privacy.file_unique_origin to false) but that solution no longer works as of FF 95(?). I think the only solution now is to host the fontawesome icons we need directly on HB? I'm not sure how that works, but looks like you can download a subset/"kit" of their icons and just host like a font?

This is merely a local development with firefox issue, so not a big deal probably for most people, though I would appreciate it :)

dbolack-ab commented 3 months ago

The Proxying solution in #3501 could be leveraged here.