search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.06k stars 324 forks source link

Trailing whitespace after \page or \column prevents tokenization #1667

Open Gazook89 opened 2 years ago

Gazook89 commented 2 years ago

In v3, trailing whitespace after \page or \column prevents those commands from working. I think this could cause a small bit of unnecessary confusion.

ericscheid commented 2 years ago

It should get noted in the intro to v3 where we intro \column.

IIRC we disallow that extra text because it would still render as plain text .. and we wanted to reserve text-after-break-token for possible future use (e.g folding labels).

Gazook89 commented 2 years ago

I think if there is ONLY whitespace, it should be disregarded?

calculuschild commented 2 years ago

My initial reaction is no.... But if it's only whitespace. Hm... I guess looking at the rest of markdown, it's usually pretty forgiving of trailing whitespace and just trims it out anyway. Maybe allowing trailing whitespace is fine?

On the other hand, it's easier to stay with a strict rule with the potential to loosen it up later. If we allow spaces now though and realize down the road that we need to disallow that, undoing that will be much more difficult.

dbolack-ab commented 2 months ago

If #3258 ends up merged, it will solve for this.