naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.08k stars 327 forks source link

Real time version window disappears after a period of time. #247

Closed RattiganIV closed 6 years ago

RattiganIV commented 7 years ago

this includes both my homebrews and the mainpage for homebrew. the window that displays the "final product" just disappears, so i cant see what i'm doing, while trying to look up the issue, the main page stopped displaying correctly as well.

update: the system works with edge, but still doesnt work with chrome

Additional Details

Share Link : http://imgur.com/ZXfE5pM or

Brew code to reproduce :

Click to expand

PASTE BREW CODE HERE

PercussiveRepair commented 7 years ago

I get the same issue. Not sure if relevant but the errors in the Chrome debug console are:

libs.js:3 Uncaught TypeError: this.debounceSave is not a function(…)
RattiganIV commented 7 years ago

this kind sucks massively, i have no idea what the issue is, breaks the whole thing because it optimized ONLY for chrome.

PercussiveRepair commented 7 years ago

Closed? Still an issue for me

stolksdorf commented 7 years ago

If other people are still having issues, I'm going to re-open this.

Docrimbo commented 7 years ago

Same here. It's a bummer.

I can see it when I "get pdf," but not while updating in real time.

stolksdorf commented 7 years ago

Not really sure what is causing this. I can't replicate it on my end. I have a feeling it's related to debounce saving getting out of sync. Pushing out an update, v2.6.1 that adds additional protection for this. Let's see if it fixes it.

PercussiveRepair commented 7 years ago

This is the brew that's currently not working for me: http://homebrewery.naturalcrit.com/edit/Hkxlxow2mx (and a previous one with the same content: http://homebrewery.naturalcrit.com/edit/Bkz9Vd-U7e) I tried creating a new one and pasting over the same text but it does the same thing. The preview works on the sample brew but as soon as I paste, the preview disappears.

Docrimbo commented 7 years ago

When I try PercussiveRepair's method, the preview disappears when I save.

stolksdorf commented 7 years ago

Thanks @PercussiveRepair, I can now replicate the issue and I know what's causing this. I'll fix it as soon as I have some free time.

Note to future me: Edge case in error handling of open tag mismatch on fresh render.

RattiganIV commented 7 years ago

My issue resolved itself spontaneously.

calculuschild commented 7 years ago

I am having the same issue. One of my brews just refuses to render.

Edit: ...aaaand it looks like it was caused by a missing end div tag.

ghost commented 7 years ago

I am currently having the same issue. I can pull up a new doc and it is fine but as soon as I save it disappears. I can get pdf just fine.

stolksdorf commented 7 years ago

Fixed in v2.7.0 ᶦ ʰᵒᵖᵉ

HiAverageJoe commented 7 years ago

Hello there, I've only been using the HomeBrewery for about a week and I am experiencing the same issue. There is no error message and I have checked every div tag with no success. My experience is similar to PercussiveRepair's.

The page with the issue. bug )

Teetengee commented 7 years ago

I am also seeing the same problem with one of my brews. As soon as I save, the display disappears. Print to PDF still works, but the real-time editing is very powerful.

http://homebrewery.naturalcrit.com/share/Hy11ypUf-

for the share

stolksdorf commented 7 years ago

@Teetengee Bad HTML and markdown mixing. Line 39. A div is being rendered within a header.

Teetengee commented 7 years ago

Thanks, I removed it and got it to display again. That being said, that code displays fine before saving and when exporting to pdf, is that expected?

calculuschild commented 6 years ago

This is the common issue #655 . As seen in the screenshot of the OP, he has an invalid <div> tag.

Closing and marking as duplicate of #655 .