search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.09k stars 326 forks source link

[FEATURE]: Brew navigation features #2812

Closed 5e-Cleric closed 1 month ago

5e-Cleric commented 1 year ago

Your idea:

Had the idea of trying to bring some of the features from pdf viewers to here, mostly for the share page, but also for the editor:

calculuschild commented 1 year ago

Zoom and page navigation could apply to edit page and share page.

Change view on share. Maybe edit page too.

Notes and reading out loud I think fit better just in a PDF reader.

5e-Cleric commented 1 year ago

Notes and reading out loud I think fit better just in a PDF reader.

share page IS a PDF reader, if not in name at least in functionality.

calculuschild commented 1 year ago

I have to disagree. The Homebrewery displays a document similar to a PDF viewer, but the Homebrewery and a PDF viewer have different purposes.

For example, you normally can't visit someone's blog and start adding sticky notes all over it, or expect a blog to have text-to-speech. You would get separate programs or browser extensions to do that for you.

If people want access to those types of features, a PDF viewer would already have them. It's not hard to just print the PDF and open it in Adobe Reader to start adding sticky notes or have it read out loud.

Gazook89 commented 1 year ago

Also, text-to-speech may not work well if a brew isn't laid out well (as in, the html structure is poor). It is likely that browser extensions exist that can speak selected text (or maybe a whole iframe?). But in any case, I agree with Calc on this one.

5e-Cleric commented 5 months ago

Working on this right now, i started with a UI similar to that used in the filter options in userpage:

image

5e-Cleric commented 5 months ago

Page navigation and zoom figured out in #3499, change view will be more complex, and left for later, if done.(would need to use zoom as well, which would get in the way)

5e-Cleric commented 2 months ago

3665 will do the rest

5e-Cleric commented 1 month ago

Multiple pages view is the only thing left, i can give it a try. i know i have achieved it before with just css.

Gazook89 commented 1 month ago

I have this pretty much done in a PR. I was holding it until the other zoom things were done, and they are, so I can push this up when I get a chance tomorrow

5e-Cleric commented 1 month ago

Closing this issue as resolved, we can keep track of multiple pages in its original issue, #1379