search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.04k stars 317 forks source link

themes option hidden by Properties tab #3224

Open ericscheid opened 6 months ago

ericscheid commented 6 months ago

Clicking the Editor Themes icon while the Properties tab is selected does not cause the themes widget to be visible. It is likely hidden behind the properties tab.

image
Gazook89 commented 6 months ago

Metadata Editor .less: z-index : 10000;

Gazook89 commented 6 months ago

Woops, didn't mean to hit submit so quickly.

So do we want to show the Theme Selector for the editor when the Metadata Editor is open, or just hide that toggle and display only when using the Style or Brew editors?

On my Theme Selector PR, I currently have the theme selector dropdown using the same gray as the metadata editor, which isn't great. But that is a moot point if we don't allow Editor theme selection when an editor isn't open/visible.

image

(or we could gray it out as 'non functional' when viewing metadata editor)

ericscheid commented 6 months ago

(or we could gray it out as 'non functional' when viewing metadata editor)

This seems reasonable. We do dim/disable the undo/redo buttons on the Properties panel.