naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.04k stars 318 forks source link

Parser can't parse end-parenthesis in URL #327

Closed BrentNewhall closed 7 years ago

BrentNewhall commented 7 years ago

End-parentheses in URLs cause the parser to stop parsing the URL at that point. For example:

Link to full image

Renders as:

Link to full image_sample.jpg

Additional Details

Brew code to reproduce :

Click to expand

Link to wikimedia page

stolksdorf commented 7 years ago

I'm assuming you are using the Markdown syntax for your image link. In that case refer to this thread about using brackets in Markdown links.

BrentNewhall commented 7 years ago

Yep, I'd found that. :-) I tried several of those alternatives -- including Bare, encoded and delimited -- and couldn't find one that worked. With HTML going away in later versions of Homebrewery, which syntax should I use if I need an end-parenthesis in a hyperlinked URL?

On Sun, Feb 12, 2017 at 11:17 AM Scott Tolksdorf notifications@github.com wrote:

I'm assuming you are using the Markdown syntax for your image link. In that case refer to this thread about using brackets in Markdown links http://meta.stackexchange.com/questions/13501/links-to-urls-containing-parentheses .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stolksdorf/homebrewery/issues/327#issuecomment-279228983, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDuL2qw6rXoIPDTB__7mp2B0oRdCB0-ks5rbzCcgaJpZM4L3hh4 .

stolksdorf commented 7 years ago

Cool. Looks like that is a bug then.

Code to test.

[test](https://commons.wikimedia.org/wiki/File:%D0%9A%D0%B0%D0%BC%D0%B5%D0%BD%D0%BD%D1%8B%D0%B9_%D0%B2%D0%B5%D0%BA_(1).jpg)
stolksdorf commented 7 years ago

Looks like it's not possible without some deep changes to the markdown lexer I'm using.

If you replace the closing paren in your url with %29 it will though.

BrentNewhall commented 7 years ago

FYI, I just tried this and it inserted the literal %29 into the URL without interpreting it as the ")" character. :-/

On Sun, Feb 12, 2017 at 6:22 PM Scott Tolksdorf notifications@github.com wrote:

Closed #327 https://github.com/stolksdorf/homebrewery/issues/327.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stolksdorf/homebrewery/issues/327#event-958842554, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDuL1qJ2NILlZEIAOJMIrzTDnGdbjoRks5rb5QxgaJpZM4L3hh4 .

stolksdorf commented 7 years ago

okay.