search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.03k stars 316 forks source link

Add Jump-To hotkeys #3483

Open dbolack-ab opened 1 month ago

dbolack-ab commented 1 month ago

This binds CTRL/META-SHIFT-RIGHTARROW to brewJump and CTRL/META-SHIFT-LEFTARROW to sourceJump.

Solves part one in https://github.com/naturalcrit/homebrewery/issues/241

edit: Reflect change in hotkey binding.

5e-Cleric commented 1 month ago

Those hotkeys are already in use in chrome For me they open downloads, and dev tools console respectively.

image

https://support.google.com/chrome/answer/157179?hl=en&co=GENIE.Platform%3DDesktop

calculuschild commented 1 month ago

Now, we don't need to add more hotkeys at all (I would actually prefer we don't). One person in the original issue only suggested it as a lesser alternative if we couldn't get scroll linking to work, but the other PR takes care of that.

dbolack-ab commented 1 month ago

Now, we don't need to add more hotkeys at all (I would actually prefer we don't). One person in the original issue only suggested it as a lesser alternative if we couldn't get scroll linking to work, but the other PR takes care of that.

As a primarily hot key user, I know I would use the keys more than the buttons and live scrolling would annoy the crap out of me.

calculuschild commented 1 month ago

Fair enough. Just didn't want to add a feature if nobody actually wanted it.

Gazook89 commented 1 month ago

I think hotkeys for navigating the page is a good idea. And this counts as navigating the page (it is changing the view).

I do think we can remove hotkeys for many snippets (and I made most of those hot keys so no one should be offended). The snippet menus themselves should have better keyboard navigation (cough radix cough), but in the meantime if there is a snippet hot key that would be better used for something else, I think it’s fine to claim it.

I intend to work on snippet menu very soon, 1) to convert to function components and 2) look at keyboard navigation and/or radix.

5e-Cleric commented 4 weeks ago

I'm sorry but:

https://homebrewery.naturalcrit.com/share/1Em9UpHcoKws3xv65lWCRGzPDr3xPAWzvp9-Fp6cxI0Ac

Ctrl-M is used to input spans.

Usual problem with hotkeys, every damn program uses them, windows, chrome, HB...