search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.1k stars 327 forks source link

[FF issue]Extra white space when trying to print after part covers #3578

Open DnDremco opened 4 months ago

DnDremco commented 4 months ago

Renderer

v3

Browser

Firefox

Operating System

Windows

What happened?

It looks like the "imageMaskEdge" causes an extra white on the next page when I'm trying to print. When I remove the mask the problem is gone.

Schermafbeelding 2024-07-15 191152

Schermafbeelding 2024-07-15 191202

Only the page after a place i used the mask is effected, the pages after that are how they look in the editor.

Link to the brew: https://homebrewery.naturalcrit.com/share/mByn4NVQS3s5

Code

No response

DnDremco commented 4 months ago

When opening the page in Edge I saw the notification that the homebrewery was build for chrome. After testing I wanted to add that this is an issue in Firefox, I don't have this problem in Edge or Chrome. If this is not something you can fix for Firefox the issue can be resolved.

5e-Cleric commented 4 months ago

Firefox is always giving problems (all browsers do) but we are aware of the issue.

@G-Ambatte is this related to #3115 ?

G-Ambatte commented 4 months ago

@G-Ambatte is this related to #3115 ?

No, this an unrelated but known issue.

For some reason the print layout of FF doesn't clip the masks to the overflow limit of the page element. Literally everything else does, which is why the intervening space is blank. If the masks don't overflow, then it's not an issue... but require a complete rebuild of how we've introduced "easy masks".