search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.07k stars 326 forks source link

Table of contents doesn't print accents in uppercase letters at the title #3638

Open MiniX16 opened 1 month ago

MiniX16 commented 1 month ago
Operating System Browser Renderer
Windows Other v3

What happened?

When creating the table of contets and trying to change its title to "Índice" (Index in spanish), the first "Í" with accent was printed without the accent.

ericscheid commented 1 month ago

It would appear that the font MrsEavesRemake needs a glyph tweak.

image
5e-Cleric commented 1 month ago

I wouldn't call a glyph tweak to adding all latin suplement uppercase characters, also have in mind, #116 is our oldest issue.

MiniX16 commented 1 month ago

Hey! I was trying to fix this as my first issue, I think I fixed it but still not working... Using a online visualizer of the font @ericscheid said I saw the problem:

image

So I decided to modify the font so it works as it should and this is the result:

image

So I replaced the font file here: /homebrewery/themes/fonts/5e/Mr Eaves Small Caps.woff2 and here /homebrewery/themes/fonts/5e legacy/Mr Eaves Small Caps.woff2, rebuild and run. Not workin :(

Any idea? Building is enough to see the changes, right? Did I modified the correct file?

dbolack-ab commented 1 month ago

Hey! I was trying to fix this as my first issue, I think I fixed it but still not working... Using a online visualizer of the font @ericscheid said I saw the problem:

image

So I decided to modify the font so it works as it should and this is the result:

image

So I replaced the font file here: /homebrewery/themes/fonts/e5/Mr Eaves Small Caps.woff2 and here /homebrewery/themes/fonts/e5 legacy/Mr Eaves Small Caps.woff2, rebuild and run. Not workin :(

Any idea? Building is enough to see the changes, right? Did I modified the correct file?

/homebrewery/themes/fonts/e5/Mr Eaves Small Caps.woff2 or homebrewery/themes/fonts/5e/Mr Eaves Small Caps.woff2

5e-Cleric commented 1 month ago

Do we want to modify the Legacy font? we can do it, but @MiniX16 for the future, you don't need to update anything in the legacy version. I believe there was consensus on leaving that as it, with bugs and all. I do think a font change this small won't break anything.

This looks good.