search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.07k stars 326 forks source link

White shear lines on masked images #3656

Open lucastucious opened 3 weeks ago

lucastucious commented 3 weeks ago

Renderer

v3

Browser

Chrome

Operating System

Windows

What happened?

See issue on reddit : https://www.reddit.com/r/homebrewery/comments/1es0me9/white_shear_lines_appear_on_my_images_when_i/

Basically, there is a some lines appaearing on the export in masked images

Code

No response

lucastucious commented 3 weeks ago

image Here is some extreme values to show the issue. I've tried many things in css to fix this but it seems like it's a bug from the chrome printing engine

G-Ambatte commented 3 weeks ago

Correct, it actually appears worse in the Print Preview than it is in the actual output PDF - it's still present, just far less visually noticeable.

As best I can tell, it has to do with the transform which rotates the mask leaving an unclean edge at the point that it tiles. There isn't much we can do about it directly, as it is a Chrome bug.

The workaround at the moment is to adjust the scale parameters to move the white lines out of the visible area.... Unfortunately there is also a bug with mask scaling that causes image skewing (#3636) but the fix has been created, it just needs to be approved and hopefully will be in the next release to go live on the site.

...also I'm certain this has been reported before, although I can't find an open issue right now.