search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.1k stars 326 forks source link

Legacy Brews cannot be viewed #3764

Closed G-Ambatte closed 1 month ago

G-Ambatte commented 1 month ago

A recent change to the BrewRenderer is causing Legacy brews to be unable to render at all on the SharePage. The issue appears to be from a recent change to line 144 of BrewRenderer.jsx, changing props.currentEditorPage to props.currentEditorPage - 1.

REPRODUCTION STEPS:

  1. Attempt to open the Share page of any Legacy brew, new or old, with or without actual content.

EXPECTED RESULT: Brew is rendered

CURRENT RESULT: Loading icon sits on page forever. Page background image does not load.

G-Ambatte commented 1 month ago

Looks like the simple fix is to change the default value of props.currentEditorCursorPageNum from 0 to 1 on line 58 of that file.