naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.1k stars 326 forks source link

Zooming doesn’t work well on iOS #3883

Open Gazook89 opened 5 days ago

Gazook89 commented 5 days ago

Renderer

Both

Browser

Firefox

Operating System

other

What happened?

Zooming doesn’t work well on iOS/iPadOS. The font size isn’t adjusted (or is counteracted) for the zoom, so text quickly flows out of the columns.

This stack overflow answer describes why, and I’m assuming the fix mentioned works though I haven’t had opportunity to try yet.

https://stackoverflow.com/a/64998974

image

fixing this will go a long way to making it work better on mobile I think, at least for viewing shared brews.

Code

No response

5e-Cleric commented 5 days ago

I see a bunch of issues to resolve there:

Gazook89 commented 4 days ago

Okay yes, but this issue is about one thing with a single line fix (maybe a couple lines). I wouldn’t get distracted by those other things

Gazook89 commented 2 days ago

Okay, am home now and can fiddle with this a bit. Ultimately, i don't think it works or at least i can't get it to.

Relevant info:

I cannot get -webkit-text-size-adjust to work

So kind of frustrating. I was testing with Safari and using my iphone to test it.

I likely won't fuss with it much more but wanted to record my experience with it.