search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.1k stars 327 forks source link

Page shadows checkbox in toolbar page view options is not working #3919

Closed 5e-Cleric closed 12 hours ago

5e-Cleric commented 4 days ago

The page shadows checkbox currently has no effect on the actual shadow of the pages as of today. It's likely a last minute change to fix or clear some other function that broke it.

Gazook89 commented 3 days ago

I think it needs to be fixed right here, adding a dependency to the useMemo for displayOptions.pageShadows to the renderPages function:

https://github.com/naturalcrit/homebrewery/blob/e28b4e8c204e36041991fea92fd350c30fa05efd/client/homebrew/brewRenderer/brewRenderer.jsx#L220

renderedPages = useMemo(()=>renderPages(), [displayOptions.pageShadows, props.text]);