search

naturalcrit / homebrewery

Create authentic looking D&D homebrews using only markdown
https://homebrewery.naturalcrit.com
MIT License
1.03k stars 315 forks source link

Editor issues with touch screens #715

Open ericscheid opened 5 years ago

ericscheid commented 5 years ago

When editing on iOS (iPad, Safari) and I press the shift-key, it behaves as if it is locked on (despite being displayed as a normal shift-enabled state - i.e. not solid up-arrow with underbar).

That is, if I press this sequence of keys: shifttitle the editor will then contain TITLE, and not Title.

Oh, the number of times I've written a title like #HERE is THE magic OF the THING (which is meant to be word-capped), or simply HERE IS A SENTENCE WHERE I HAVE TYPED MUCH WORDS VERY CAPS BEFORE REALISING IS ALL CAPS ARGHDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDELDEL.

As noted above, the shift key has the appearance of one-tap-enabled, but behaves as if caps-locked. (Well, technically shift-locked, as Shift,! actually produces the !). If I had to guess, the page is consuming the keypress but not reflecting as having been typed, and thus the keyboard isn't releasing the shift-once state.

This behaviour does not happen on MacOS in Chrome.
Does this happen on other mobile platforms?

I'd like to fix this behaviour as it is incredibly annoying, but I'm guessing it's more a case of react/javascript shenanigans than simply tweaking html5 autocapitalization attribute value.

ericscheid commented 3 years ago

Found mentions of this being an issue with React Native and causing issues with other projects.

Gazook89 commented 2 years ago

@ericscheid I just tried this on iOS (iphone) Safari and Firefox and do not have the same issue. Want to double check and see what happens now? I don't have iPad to be definitely sure.

calculuschild commented 2 years ago

I know Codemirror has issues with mobile devices, specifically touch-interaction. Was this using touch or a separate keyboard? If touch, eventually when Codemirror 6 releases we can switch to that which solves a lot of the problems with touch screens.

Gazook89 commented 2 years ago

All I'm hearing is @calculuschild enthusiastic support for responsibe, mobile friendly redesign

:)

ericscheid commented 2 years ago

Tested on iPad IOS 12.5.4 with touch keybord — still occurs.

dbolack-ab commented 1 week ago

Is this still occurring?

calculuschild commented 1 week ago

Fixing this requires upgrading to Codemirror 6.