naturalis / brassica-genes

Analysis of flowering time paralogues in Brassica oleracea
MIT License
0 stars 0 forks source link

Feedback script #4

Open rvosa opened 5 years ago

rvosa commented 5 years ago
hfrijmann commented 5 years ago

First point is true, we went for functionality first as a argument parses is new territory and not strictly necessary (although desirable) for functionality. It is planned to be included on a later time. The targeted search is done by a simple selection step done by a script that has not been uploaded yet, as it's created by another project member! So when this script reads the GFF3 file it does search for ALL genes, but that GFF3 list will only contain the genes of interest. The other two recommendations are solid! I will review these and update the program when necessary!

rvosa commented 5 years ago

Ok, sounds good. If the splicing is a two-step process (I agree that that is reasonable) then go ahead and do it that way, just make sure you document this clearly. Good luck on the other issues: if you think you have reasonably addressed them you can check their respective boxes so that we can see how we're progressing.