search

nature-of-code / Nature-of-Code-Website-Archive

Repo for web files for nature of code
https://noc-processing-archive.netlify.app/
111 stars 21 forks source link

Change colour of links to pass the WCAG contrast ratio guidelines and… #29

Open wormmoon opened 6 years ago

wormmoon commented 6 years ago

… make them readable

Current colour #30def6 has a low contrast ratio with the background colour #f6f6f6 and may be unreadable for some people. Does not pass test on https://contrast-ratio.com/. New colour #237480 does pass this test.

shiffman commented 6 years ago

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.
wormmoon commented 6 years ago

Thank you so much for this! ❤️❤️❤️

I'm working with some collaborators at ITP to make the materials more WCAG compliant and this is super helpful. A couple quick comments:

  1. If possible, can you include a screenshot illustrating the difference (this is helpful when reviewing pull requests!)
  2. Ultimately, this change will need to be made in The Nature of Code book source repo as this is what generates the html/css/etc files that I transfer over here when updating the book content.

Ahh thank /you/ for this book!

Okay I will do this today!

shiffman commented 2 years ago

Apologies that this was never addressed! I am working on a new design that I would will be more accessible at https://github.com/nature-of-code/book-website-2nd-edition