search

nature-of-code / noc-book-2

The 2024 edition of The Nature of Code with p5.js. Includes Notion workflow and build system.
https://natureofcode.com
1.19k stars 82 forks source link

Missing "BBB" on Figure 8.21 #1047

Open shiffman opened 3 weeks ago

shiffman commented 3 weeks ago

In class this week I noticed that the B's are missing from the 3rd row of illustration 8.21. This is what is in the book:

image

This is the correct image is in #297

image

@zee-em since this and #981 are just "text" elements in the illustrations I could perhaps make these changes myself? What do you think?

zee-em commented 6 days ago

I've fixed this one, uploaded to notion and PNG & Procreate files to Google drive... here's the new image. Hopefully the spacing of the Bs is ok. I remember this one was the bbbane of my existence Figure_8-22

shiffman commented 10 hours ago

Hi @zee-em so adding the three B's into the image seems to have moved the A's and B's around in the bottom two rows. The lines are all in the correct places, but the following rules are not being applied correctly:

  1. An A appears centered below a horizontal line.
  2. A B appears centered below a blank space.

See the original image for an exact version:

image

The bottom row from what we had before you made the change was correct (well, the letters are slightly out of place but I think well within reason given it's hand drawn illustration.)

image

But in the new version you just added the A's and B's are in weird definitely inplaces.

image

The letters in the third row are also now in incorrect positions, the spacing should be perfectly even in each row.

image

Let me know if this makes sense!