Closed jasongao97 closed 2 months ago
Name | Link |
---|---|
Latest commit | 1d277d7b1e334ba1c1bb4307e1fbf3758713c27c |
Latest deploy log | https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/65f0504a81b38b00089abcf4 |
Deploy Preview | https://deploy-preview-912--nature-of-code-2nd-edition.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 1d277d7b1e334ba1c1bb4307e1fbf3758713c27c |
Latest deploy log | https://app.netlify.com/sites/nature-of-code-pdf/deploys/65f0504ac8ac5f00088eb08b |
Deploy Preview | https://deploy-preview-912--nature-of-code-pdf.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Yes, let's try it! I am going to be comparing the PDF side by side with the latest markup from no starch so I can look carefully and make sure nothing else has changed. There is a merge conflict now though I'm not sure where that came from, can you check? Thank you!
Resolve #909
Before
After
The bug occurs because the scissors were added to the last chunk of code:
, which span across two pages, and Prince XML decides to make the relative origin on the first page.
This PR break the code chunk into individual lines and ensure the last chunk will be located on the later page.
@shiffman This change applies globally and have the potential of affecting certain areas. I have reviewed the PDF briefly and did not detect any issues. Could we implement this for now, and if anything breaks, I can work on a local solution?