[Fix] Check if maxLines is `undefined`

nature-of-code / noc-book-2

Nature of Code with p5.js and Notion workflow / build system.

https://natureofcode.com

762 stars 52 forks source link

Closed jasongao97 closed 2 months ago

jasongao97 commented 2 months ago

Switch the if condition from:

!!pair.maxLines

to:

pair.maxLines !== undefined

since 0 could be a valid number and the first one won't work

netlify[bot] commented 2 months ago

Name	Link
Latest commit	deab9e9faa4192450091a8e0addcf93d7137e538
Latest deploy log	https://app.netlify.com/sites/nature-of-code-pdf/deploys/65f0189c0d6ca80008a1a8fe
Deploy Preview	https://deploy-preview-913--nature-of-code-pdf.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Name	Link
Latest commit	deab9e9faa4192450091a8e0addcf93d7137e538
Latest deploy log	https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/65f0189c8e86df00077bdd29
Deploy Preview	https://deploy-preview-913--nature-of-code-2nd-edition.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.