search

nature-of-code / noc-book-2

Nature of Code with p5.js and Notion workflow / build system.
https://natureofcode.com
762 stars 52 forks source link

notion-fetch update? #918

Closed shiffman closed 2 months ago

shiffman commented 2 months ago

I wonder if me renaming the repo caused this issue, naming it back to noc-book-2023 temporarily to check.

https://github.com/nature-of-code/noc-book-2023/actions/runs/8256059741

Screen Shot 2024-03-12 at 5 41 25 PM
shiffman commented 2 months ago

whether renaming the repo broke something, changing it back doesn't seem to fix it. maybe just a coincidence and an update is needed. @jasongao97 can you take a look?

jasongao97 commented 2 months ago

This issue is caused by some images in Chapters 7 and 8 that are still referencing the old GitHub repo. I have replaced all of them and checked. The most recent build was passed: #919.

shiffman commented 2 months ago

This can be closed after @jasongao97 just briefly reviews #920 and #919 to make sure they are identical.

shiffman commented 2 months ago

This is all set now!