nature-of-code / noc-book-2

Nature of Code with p5.js and Notion workflow / build system.
https://natureofcode.com
762 stars 52 forks source link

Double-Checking Changes I made manually #920

Closed shiffman closed 2 months ago

shiffman commented 2 months ago

Related to #918 when the notion build was failing due to the archive repo renaming I made some changes manually to the HTML. I need to cross-reference these changes with #919 to make sure I didn't miss anything. I think I'll merge #919 first and then see if there are merge conflicts with this branch? I'm not sure.

netlify[bot] commented 2 months ago

Deploy Preview for nature-of-code-2nd-edition ready!

Name Link
Latest commit a274569eff334c2cc2545a7ca3e7339849f69358
Latest deploy log https://app.netlify.com/sites/nature-of-code-2nd-edition/deploys/65f21dc3ea46ee0008920167
Deploy Preview https://deploy-preview-920--nature-of-code-2nd-edition.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for nature-of-code-pdf ready!

Name Link
Latest commit a274569eff334c2cc2545a7ca3e7339849f69358
Latest deploy log https://app.netlify.com/sites/nature-of-code-pdf/deploys/65f21dc3da0f1f0008f8931b
Deploy Preview https://deploy-preview-920--nature-of-code-pdf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shiffman commented 2 months ago

This should not be merged! It looks like the changes here are identical to those in #919 so I think I am good to go to close this. @jasongao97 can you check this over as well just to make sure? There is one conflict but I think those lines are identical and git just marked it as a conflict unecessarily.

Thank you!

shiffman commented 2 months ago

I've checked this over a few times and the PDF looks identical so I think we're all good! @jasongao97 let me know if you think I missed anything!