search

nature-of-code / noc-book-2

Nature of Code with p5.js and Notion workflow / build system.
https://natureofcode.com
762 stars 52 forks source link

cpt 10: column titles #929

Closed ManoylovAC closed 1 month ago

ManoylovAC commented 1 month ago

Several tables have the same column header names: "phrase". Perhaps these names should be reviewed.

image image image image

https://github.com/nature-of-code/noc-book-2/blob/fd14992f4130bd679758da87245ac1aafd2b1060/content/10_nn.html#L80

https://github.com/nature-of-code/noc-book-2/blob/fd14992f4130bd679758da87245ac1aafd2b1060/content/10_nn.html#L102

https://github.com/nature-of-code/noc-book-2/blob/fd14992f4130bd679758da87245ac1aafd2b1060/content/10_nn.html#L121-L124

https://github.com/nature-of-code/noc-book-2/blob/fd14992f4130bd679758da87245ac1aafd2b1060/content/10_nn.html#L201-L202

https://github.com/nature-of-code/noc-book-2/blob/fd14992f4130bd679758da87245ac1aafd2b1060/content/10_nn.html#L293-L294

shiffman commented 1 month ago

Wow, this is a major error, thank you for catching this! Just under the wire before it goes to print.

shiffman commented 1 month ago

This should be fixed in #930, @ManoylovAC feel free to take a look and make sure I got it right!

ManoylovAC commented 1 month ago

Yes, great - now the tables look as they should